fix(oxfmt): Skip `vite.config.ts` w/o `.fmt` field in auto-discovery by leaysgur · Pull Request #20254 · oxc-project/oxc

leaysgur · 2026-03-12T02:40:09Z

Fixes #20237

leaysgur · 2026-03-12T02:40:23Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR adjusts oxfmt config auto-discovery so that vite.config.ts is only treated as an Oxfmt config when it contains the expected .fmt field, while keeping explicit --config vite.config.ts strict (erroring if .fmt is missing).

Changes:

Split explicit config loading vs upward auto-discovery, and add “skip vite.config.ts without .fmt” behavior during auto-discovery.
Plumb config_dir (not “config path”) into the walker so ignorePatterns resolve relative to the loaded config directory.
Extend CLI snapshot tests/fixtures to cover explicit-error vs auto-discovery-skip behavior (including “skip child vite config, find parent config”).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
apps/oxfmt/src/core/config.rs	Implements explicit-load vs auto-discovery; skips `vite.config.ts` without `.fmt`; adds `config_dir()` accessor.
apps/oxfmt/src/cli/format.rs	Switches to `ConfigResolver::from_config` for discovery; uses `config_dir()` for ignorePatterns and “no config” hint logic.
apps/oxfmt/src/cli/walk.rs	Changes ignorePatterns root from config file path to `config_dir`.
apps/oxfmt/src/stdin/mod.rs	Routes `--config` directly into `ConfigResolver::from_config` (no separate path resolver).
apps/oxfmt/src/lsp/server_formatter.rs	Removes `resolve_oxfmtrc_path` usage; passes optional config path directly to `ConfigResolver::from_config`.
apps/oxfmt/src/core/mod.rs	Stops exporting the removed `resolve_oxfmtrc_path`.
apps/oxfmt/test/cli/vite_config/vite_config.test.ts	Adds test cases for explicit `--config` error vs auto-discovery skip behavior.
apps/oxfmt/test/cli/vite_config/snapshots/vite_config.test.ts.snap	Updates/adds snapshots for the new CLI behaviors.
apps/oxfmt/test/cli/vite_config/fixtures/skip_finds_parent/**	Adds fixtures to validate skipping child `vite.config.ts` and finding a parent `.oxfmtrc.json`.

You can also share your feedback on Copilot code review. Take the survey.

apps/oxfmt/src/core/config.rs

graphite-app · 2026-03-12T04:14:03Z

Merge activity

Mar 12, 4:14 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Mar 12, 4:25 AM UTC: Merged by the Graphite merge queue.

…20254) Fixes #20237

#20255) The same as #20254 for Oxlint. The refactoring to move the logic to the JS side is being addressed in a subsequent PR. (Copilot review will be also addressed)

# Oxlint ### 🐛 Bug Fixes - 4ea67de oxlint,oxfmt: Skip `vite.config.ts` exports `defineConfig(fn)` (#20260) (leaysgur) - cc89dbf oxlint: Skip `vite.config.ts` w/o `.lint` field in auto-discovery (#20255) (leaysgur) - 89b7ca9 linter/no-duplicate-imports: Only check aggregated exports (#20178) (kennytm) - 691f556 linter/explicit-module-boundary-types: Ignore constructor callbacks (#20221) (camc314) ### ⚡ Performance - d160dca linter/plugins: Reduce array lookups in visitor compilation (#20249) (overlookmotel) ### 📚 Documentation - 0c7da4f linter: Fix extra closing brace in example config. (#20253) (connorshea) - 13606c3 linter/plugins: Update conformance README (#20234) (overlookmotel) # Oxfmt ### 🐛 Bug Fixes - 4ea67de oxlint,oxfmt: Skip `vite.config.ts` exports `defineConfig(fn)` (#20260) (leaysgur) - 11a2b45 oxfmt: Skip `vite.config.ts` w/o `.fmt` field in auto-discovery (#20254) (leaysgur) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>

jamesbvaughan · 2026-03-13T16:56:18Z

I believe I'm still hitting the issue that this was meant to solve with oxfmt v0.40.0.

❯ yarn client format:oxfmt
Failed to load configuration file.
/Users/james/code/project/apps/client/vite.config.ts
Ensure the file has a valid default export of a JSON-serializable configuration object.

This is in a monorepo with a root-level .oxfmtrc.jsonc and no fmt field in the file referenced in that error.

Let me know if it would be helpful to put together a minimal reproduction.

camc314 · 2026-03-13T17:22:56Z

can you sure your vite config @jamesbvaughan

jamesbvaughan · 2026-03-13T22:50:39Z

I've spent some time trying to narrow down the issue and found that the content of vite.config.ts is irrelevant for the specific way I'm hitting the error. The file can be completely empty and it doesn't change the result.

I believe I've narrowed the problem down to something involving either Volta or differences in Node versions.

I have a minimal repro in a repo with this structure:

.
├── apps
│   └── client
│       ├── package.json
│       └── vite.config.ts
├── package.json
└── yarn.lock

Where the root package.json is:

{
  "name": "oxfmt-issue-demo",
  "workspaces": {
    "packages": [
      "apps/*"
    ]
  },
  "type": "module",
  "devDependencies": {
    "oxfmt": "^0.40.0"
  },
  "volta": {
    "node": "22.16.0"
  },
  "packageManager": "yarn@4.13.0"
}

It doesn't matter what's in vite.config.ts. If I change the node version specified in that root package.json from 22.16.0 to 22.20.0, the issue goes away and I can run yarn workspace client oxfmt without issue.

jamesbvaughan · 2026-03-13T23:44:09Z

Actually it seems that this will be fixed in the next release for me. The change in this PR fixed my issue: #20326

Copilot AI review requested due to automatic review settings March 12, 2026 02:40

github-actions bot added A-cli Area - CLI A-formatter Area - Formatter labels Mar 12, 2026

leaysgur mentioned this pull request Mar 12, 2026

fix(oxlint): Skip vite.config.ts w/o .lint field in auto-discovery #20255

Merged

github-actions bot added the C-bug Category - Bug label Mar 12, 2026

This was referenced Mar 12, 2026

refactor(oxlint): extract vite lint config in JS loader #20256

Merged

refactor(oxfmt): extract vite fmt config in JS loader #20257

Merged

Copilot started reviewing on behalf of leaysgur March 12, 2026 02:40 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

apps/oxfmt/src/core/config.rs Show resolved Hide resolved

leaysgur changed the title ~~fix(oxfmt): Skip vite.config.ts w/o .fmt field in auto-discovery~~ fix(oxfmt): Skip vite.config.ts w/o .fmt field in auto-discovery Mar 12, 2026

leaysgur force-pushed the 03-12-fix_oxfmt_skip_vite.config.ts_w_o_.fmt_field_in_auto-discovery branch from 2308d45 to 079cd61 Compare March 12, 2026 02:52

leaysgur mentioned this pull request Mar 12, 2026

fix(oxlint,oxfmt): Skip vite.config.ts exports defineConfig(fn) #20260

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026

fix(oxfmt): Skip vite.config.ts w/o .fmt field in auto-discovery (#…

11a2b45

…20254) Fixes #20237

graphite-app bot force-pushed the 03-12-fix_oxfmt_skip_vite.config.ts_w_o_.fmt_field_in_auto-discovery branch from 079cd61 to 11a2b45 Compare March 12, 2026 04:14

graphite-app bot merged commit 11a2b45 into main Mar 12, 2026
19 checks passed

graphite-app bot deleted the 03-12-fix_oxfmt_skip_vite.config.ts_w_o_.fmt_field_in_auto-discovery branch March 12, 2026 04:25

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026

Boshen mentioned this pull request Mar 12, 2026

release(apps): oxlint v1.54.0 && oxfmt v0.39.0 #20267

Merged

miyaoka mentioned this pull request Mar 14, 2026

Revert oxfmt to 0.37.0 miyaoka/orkis#73

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(oxfmt): Skip `vite.config.ts` w/o `.fmt` field in auto-discovery#20254

fix(oxfmt): Skip `vite.config.ts` w/o `.fmt` field in auto-discovery#20254
graphite-app[bot] merged 1 commit intomainfrom
03-12-fix_oxfmt_skip_vite.config.ts_w_o_.fmt_field_in_auto-discovery

leaysgur commented Mar 12, 2026 •

edited

Loading

Uh oh!

leaysgur commented Mar 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Mar 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

jamesbvaughan commented Mar 13, 2026

Uh oh!

camc314 commented Mar 13, 2026

Uh oh!

jamesbvaughan commented Mar 13, 2026

Uh oh!

jamesbvaughan commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

leaysgur commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaysgur commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

graphite-app bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

jamesbvaughan commented Mar 13, 2026

Uh oh!

camc314 commented Mar 13, 2026

Uh oh!

jamesbvaughan commented Mar 13, 2026

Uh oh!

jamesbvaughan commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leaysgur commented Mar 12, 2026 •

edited

Loading

leaysgur commented Mar 12, 2026 •

edited

Loading

graphite-app bot commented Mar 12, 2026 •

edited

Loading